Hi,
>From my side the decision to replace the ANTLR based parser with an own >implementation was good and it is nice to see the result on the feature branch. After a look into I give a „+1“ for merge the feature branch (OLINGO-834_Filter_Parser ) into the master. Best Regards, Michael > On Jan 8, 2016, at 2:45 PM, Amend, Christian <[email protected]> wrote: > > > Hi, > > > There has been some refactoring going on for the URI parser on this branch: > https://git-wip-us.apache.org/repos/asf?p=olingo-odata4.git;a=shortlog;h=refs/heads/OLINGO-834_Filter_Parser > > > The goal was to get rid of the ANTLR dependencies which was achieved. All > previous tests are running smoothly but I wanted to give the community a > chance to give feedback if you like since this is a rather large change. > If there are no objections I would merge the code into the master branch on > Monday next week. > > > Afterwards we can work on the other open URI parser issue which was opened in > our JIRA: https://issues.apache.org/jira/browse/OLINGO-846 > > > Best Regards, > Christian >
