[ 
https://issues.apache.org/jira/browse/OLINGO-887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Amend resolved OLINGO-887.
------------------------------------
       Resolution: Fixed
         Assignee: Christian Amend
    Fix Version/s: (Java) V4 4.2.0

This was an issue in the test. It did not have the correct timezone set to do a 
hard String compare. I changed that with this commit: 
https://git-wip-us.apache.org/repos/asf?p=olingo-odata4.git;a=commit;h=d040afe78456b14632b9cefa46441830310f7d6c

This should ensure that the test runs the same in every environment.

> Failure in EdmDateTest.valueToString:56
> ---------------------------------------
>
>                 Key: OLINGO-887
>                 URL: https://issues.apache.org/jira/browse/OLINGO-887
>             Project: Olingo
>          Issue Type: Bug
>          Components: odata4-commons
>    Affects Versions: (Java) V4 4.2.0
>            Reporter: Michael Bolz
>            Assignee: Christian Amend
>            Priority: Minor
>             Fix For: (Java) V4 4.2.0
>
>
> Since a few days (and I guess [this 
> commit|https://git1-us-west.apache.org/repos/asf?p=olingo-odata4.git;a=commit;h=7b26cc6ee7515b4f2657fe9756862882ead7f26d])
>  I get following test failure in 
> {{org.apache.olingo.commons.core.edm.primitivetype.EdmDateTest.valueToString(...)}}:
> {code}
> Failed tests:
>   EdmDateTest.valueToString:56 expected:<2012-0[2-29]> but was:<2012-0[3-01]>
> {code}
> Based on the commit, the test code (see below), my none english (german) 
> environment and the fact that the official build on [Apache 
> Jenkins|https://builds.apache.org/job/olingo-odata4] runs without failure, I 
> guess that the test should be changed that it is independent from the 
> environment or the change in the {{EdmDate}} should be reviewed.
> {code}
>     final Long millis = 1330558323007L;
>     assertEquals("2012-02-29", instance.valueToString(millis, null, null, 
> null, null, null));
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to