[ 
https://issues.apache.org/jira/browse/OLINGO-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874420#comment-15874420
 ] 

Kavindu Dodanduwa commented on OLINGO-1066:
-------------------------------------------

Hi [~mirbo]

I went through your changes and I'm also in favor of your suggestion of having 
separate classes (Instead of  the inner classes we have now).

Going through the code I saw that for a given data type (ex:- EdmPrimitiveType) 
what differs between Json or Xml implementations is the Serializer instance.

For example {{PrimitiveStreamContentForJson}} and 
{{PrimitiveStreamContentForXml}} is same except for related serializer. If we 
can come up with an abstracted serializer, for example 
{{ODataStreamSerializer}} containing stream related abstracts which are 
implemented by ODataJsonSerializer and ODataXmlSerializer we could have a nicer 
class structure IMO (All extending from {{StreamContent}})

I can try this solution if you think it's the way forward.

regards,
Kavindu 

> Stream support for Primitive and Complex type collections
> ---------------------------------------------------------
>
>                 Key: OLINGO-1066
>                 URL: https://issues.apache.org/jira/browse/OLINGO-1066
>             Project: Olingo
>          Issue Type: New Feature
>          Components: odata4-server
>    Affects Versions: (Java) V4 4.4.0
>            Reporter: Kavindu Dodanduwa
>            Assignee: Michael Bolz
>            Priority: Minor
>              Labels: features
>         Attachments: patch.diff
>
>
> Olingo currently doesn't support streaming support for serialization of 
> primitive and complex collection type responses.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to