[
https://issues.apache.org/jira/browse/OLINGO-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937978#comment-15937978
]
Christian Amend commented on OLINGO-1021:
-----------------------------------------
Hi Dmitry,
thanks for the patch :) I will look at it this evening.
What is the default now after your contribution? Strict or non-strict?
Best Regards,
Christian
> Unable to consume batch request with missing CRLF in request line
> -----------------------------------------------------------------
>
> Key: OLINGO-1021
> URL: https://issues.apache.org/jira/browse/OLINGO-1021
> Project: Olingo
> Issue Type: Bug
> Components: odata2-core
> Affects Versions: V2 2.0.7
> Reporter: Dmitry Tretyakov
> Priority: Critical
> Labels: patch
> Fix For: V2 2.0.9
>
> Attachments:
> 0002-OLINGO-1021-Add-ability-to-use-non-strict-batch-pars.patch
>
>
> Currently {{BatchParser}} throws BatchException(MISSING_BLANK_LINE) when
> request method does not end with double CRLFs and this case reproduced in the
> test {{BatchRequestParserTest#testGetRequestMissingCRLF}}
> This behavior makes odata2-core incompatible with all implementations of .net
> OData clients based on {{System.Data.Services.Client}} because it use only
> one CRLF at the end of request line:
> http://referencesource.microsoft.com/#System.Data.Services.Client/Client/System/Data/Services/Client/DataServiceContext.cs,3277289aacaeb96c
> which results in the following request body:
> {code}
> --batch_86108a65-4dc2-4c0c-bd92-384be755c83a
> Content-Type: application/http
> Content-Transfer-Encoding: binary
> GET https://www.nuget.org/api/v2/Packages HTTP/1.1
> --batch_86108a65-4dc2-4c0c-bd92-384be755c83a--
> {code}
> I see that {{BatchParser}}'s constructor allows to use non strict flag, but
> at the moment it's impossible to set due to hardcoded value in
> ProviderFacadeImpl#parseBatchRequest method.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
