[ 
https://issues.apache.org/jira/browse/OLINGO-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049987#comment-16049987
 ] 

Michael Bolz commented on OLINGO-1119:
--------------------------------------

Hello [~kra...@kraven.org],

In general code from the library core should not be directly used because for 
those parts it can not be guaranteed that all changes as backward compatible.
The reason for the code change was that the {{UriInfoType}} enum is only used 
by the {{JPAQueryBuilder}} and should therefore not exposed.

In the {{CustomJpaQueryBuilder}} you mentioned the use of the Olingo internal 
(core) {{UriInfoType}} is really not required or necessary.
It should be replaced by an own (e.g. in the {{CustomJpaQueryBuilder}} defined) 
enum.

Kind Regards, Michael



> UriInfoType enum change to private breaking change
> --------------------------------------------------
>
>                 Key: OLINGO-1119
>                 URL: https://issues.apache.org/jira/browse/OLINGO-1119
>             Project: Olingo
>          Issue Type: Bug
>          Components: odata2-jpa
>    Affects Versions: V2 2.0.8
>            Reporter: Benjamin Runnels
>            Assignee: Michael Bolz
>
> This changeset switched JPAQueryBuilder.UriInfoType to private.
> https://github.com/apache/olingo-odata2/commit/3ed58899d76c57ef8a26a3a02098c736f4740856
> I have code extending ODataJPAQueryExtensionEntityListener that was using the 
> UriInfoType  enum.  I upgraded from olingo 2.0.7 to olingo 2.0.8 and making 
> that enum private is a breaking change.  Is there a reason this was changed?  
> Do you have an alternative I should be using?
> Here's a link to the CustomQueryBuilder that it breaks.  
> https://github.com/hwestphal/spring-boot-odata/blob/master/src/main/java/io/github/hwestphal/odata/server/CustomJpaQueryBuilder.java



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to