[
https://issues.apache.org/jira/browse/OLINGO-1223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331963#comment-16331963
]
Christian Amend commented on OLINGO-1223:
-----------------------------------------
Hi Manuel,
a patch always helps especially if it includes tests :) We have a guide here on
the contribution process: [http://olingo.apache.org/contribute.html]
Pull requests like in GitHub are unfortunately not possible because the Github
<-> Apache Git Rpo integration is replication based. We can`t make changes to
the GitHub repo and we can`t link pull requests.
As for your proposed changes: Sometimes the developer decided to make a class
final to explicitly prevent extension. Especially core classes can change their
implementation between versions and should not be extended. The goal would
rather be to either register hooks that can be used or some other sort of
mechanism that stays stable through releases.
WDYT?
Best Regards,
Christian
> Remove final declaration from mulitple classes to make them extensible
> ----------------------------------------------------------------------
>
> Key: OLINGO-1223
> URL: https://issues.apache.org/jira/browse/OLINGO-1223
> Project: Olingo
> Issue Type: Wish
> Components: odata2-jpa
> Affects Versions: V2 2.0.10
> Reporter: Manuel Blechschmidt
> Priority: Minor
>
> Hello,
> we are using Olingo a lot and it is an awesome library. The extensibility and
> modularity is well designed.
> Unfortunately we needed some extensions for classes that are declared final.
> * We added an localization feature that on the fly calls other functions
> than getter or setters. we copied the following files and modified around 5%
> of the source:
> ** org.apache.olingo.odata2.jpa.processor.core.access.data.JPAEntityParser
> ** org.apache.olingo.odata2.jpa.processor.core.ODataJPAResponseBuilderDefault
> Further there are other classes that I might want to extend:
> * org.apache.olingo.odata2.jpa.processor.core.ODataEntityParser
> * ...
> If it helps I can prepare a pull request where I remove all the final
> declerations.
> /Manuel
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
