[ 
https://issues.apache.org/jira/browse/OLINGO-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl J. Mosca closed OLINGO-14.
-------------------------------


Looks good, thank you Chandan.
                
> enumerated type
> ---------------
>
>                 Key: OLINGO-14
>                 URL: https://issues.apache.org/jira/browse/OLINGO-14
>             Project: Olingo
>          Issue Type: Improvement
>          Components: odata2-jpa
>    Affects Versions: 1.0.0
>            Reporter: Carl J. Mosca
>            Assignee: Chandan V.A
>            Priority: Minor
>              Labels: test
>             Fix For: 1.0.0
>
>
> In looking at the JPA unit tests while trying to learn about the support for 
> ManyToOne I noticed that 
> org.apache.olingo.odata2.processor.core.jpa.model.JPAEdmPropertyTest includes 
> a ManyToOne test.
> The ATTRIBUTE_TYPE is set to a constant twice( (3 then 1).  I wondered if it 
> might be more appropriate to do
> ATTRIBUTE_TYPE = Attribute.PersistentAttributeType.MANY_TO_ONE.ordinal();
> instead of
> ATTRIBUTE_TYPE = 1;
> I also am wondering if the ATTRIBUTE_TYPE = 1 should have been ATTRIBUTE_TYPE 
> = 0 but I may not be understanding the test logic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to