[ 
https://issues.apache.org/jira/browse/OLINGO-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805098#comment-13805098
 ] 

Vassili Jakovlev edited comment on OLINGO-41 at 10/25/13 6:53 AM:
------------------------------------------------------------------

Thanks for a quick reply, Stephan!
One of the problems here is that core OSGi specification knows nothing about 
servlet filters, so it will be required either to use Pax Web or to package my 
bundle as WAR file, but this will make me depend on OSGi container - not all of 
them support WAR file deployment.

Maybe, it would be possible to introduce 
org.apache.olingo.odata2.core.rest.app.ODataAbstractRootLocator  where the 
functionality of retrieving service factory could be overriden without 
involving direct dependencies to org.apache.olingo.odata2.core.rest package?

public abstract class ODataAbstractRootLocator {

  ....

  protected abstract ODataServiceFactory getServiceFactory();

  ....

}


was (Author: basileus):
Thanks for a quick reply, Stephan!
One of the problems here is that core OSGi specification knows nothing about 
servlet filters, so it will be required either to use Pax Web or to package my 
bundle as WAR file, but this will make me depend on OSGi container - not all of 
them support WAR file deployment.

Maybe, it would be possible to introduce 
org.apache.olingo.odata2.core.rest.app.ODataAbstractRootLocator  where the 
functionality of retrieving service factory could be overriden without 
involving direct dependencies to org.apache.olingo.odata2.core.rest package?

public abstract class ODataAbstractRootLocator {
  ....
  protected abstract ODataServiceFactory getServiceFactory();
  ....
}

> Export-Package header incorrect in olingo-odata2-core
> -----------------------------------------------------
>
>                 Key: OLINGO-41
>                 URL: https://issues.apache.org/jira/browse/OLINGO-41
>             Project: Olingo
>          Issue Type: Bug
>          Components: odata2-core
>    Affects Versions: 1.0.0
>         Environment: Apache Karaf 2.3.3
>            Reporter: Vassili Jakovlev
>             Fix For: 1.0.0
>
>
> "Export-Package" header in olingo-odata2-core's MANIFEST.MF file misses the 
> package "org.apache.olingo.odata2.core.rest", but includes 
> "org.apache.olingo.odata2.core.rest.app". In my opinion both packages should 
> be included in "Export-Package" header and corresponding section in pom.xml 
> should look like this:
> <Export-Package>      
> org.apache.olingo.odata2.core.rest;version=${project.version},
> org.apache.olingo.odata2.core.rest.app;version=${project.version},
> org.apache.olingo.odata2.core.rt;version=${project.version},
> </Export-Package>
> PS. I need this package because it was required to create custom 
> ODataRootLocator since default ODataRootLocator accepts only fully qualified 
> factory class name, what causes problems in OSGi environment (my factory 
> class in not visible to olingo-odata2-core bundle)



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to