Hi, I've been working with Francesco and contributing to ODataJClient v4 upgrade process while working on the other project (MSOpenTech, now in progress) that used this library. There are several pull requests that didn't make it to ODataJClient repo b/c development moved here so it no longer makes sense to merge it there. I'd be happy to provide these changes here and eventually continue contributing.
Is there a place where one could take Eclipse code formatting configuration from? Thanks Maxim Kostin | AKVELON Russia (GMT +4) (m) +7 (961) 246-1297 (e) maxim.kos...@akvelon.com (s) maxkostin -----Original Message----- From: V.A, Chandan [mailto:chandan....@sap.com] Sent: Tuesday, February 18, 2014 3:14 PM To: dev@olingo.incubator.apache.org Subject: RE: [DISCUSSION] Code formatting and Jira/Git link I agree with the commit message format as it was very useful in spotting the fixes and features so +1 and +1 for code style as well Thanks, Kind Regards Chandan VA -----Original Message----- From: Amend, Christian [mailto:christian.am...@sap.com] Sent: Tuesday, February 18, 2014 4:41 PM To: dev@olingo.incubator.apache.org Subject: [DISCUSSION] Code formatting and Jira/Git link Hi, There are two things I would like to bring up which I think should be at least be brought up again to avoid confusion :) First the Jira/Git link. Every commit which states [OLINGO-<issue number>] at the beginning will be linked with the corresponding Jira issue. We once enabled that feature for the V2 repository and I think that this has proved to be quite valuable when producing release notes and looking at the commit history as it easily shows what every commit was meant for. I enabled this for the V4 repository too as there had be no votes against this at the time. So I think we should link every commit we make with a Jira issue even if they are small but WDYT? Secondly code formatting. I unfortunately destroyed Francesco formatting by applying the eclipse code style template we have in the repository, sorry for that. So what can we do to avoid such a thing in the future especially if someone is not using eclipse and thus has no way to use the formatting tools there? We have a code style which checks for braces and line length in our maven build which I think is a good thing but it does not prevent formatting the code. So WDYT? Best Regards, Christian
