[ 
https://issues.apache.org/jira/browse/OLTU-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655583#comment-13655583
 ] 

Suresh Attanayake edited comment on OLTU-78 at 5/16/13 11:10 AM:
-----------------------------------------------------------------

Hi Simone,

I went through the new code and its really simple and clean. Here are some 
inputs from me,

1. I think we should allow custom claims (public and private claims). Maybe we 
can use a map, I can provide a patch if you agree. 
2. In later implementations (JWS and JWE) we have to allow header to have more 
parameters. 
3. I would like to add spec complient checks too to the parseJWT() method. 

Thanks,
-Suresh
                
      was (Author: sureshatt):
    Hi Simone,

I went through the new code and its really simple and clean. Here are some 
inputs from me,

1. I think we should allow custom claims (public and private claims). Maybe we 
can use a map, I can provide a patch if you agree. 
2. In later implementations (JWS and JWE) we have to allow header to have more 
parameters. 
3. I would like to add spec compliment checks too to the parseJWT() method. 

Thanks,
-Suresh
                  
> Implement Plaintext JWT 
> ------------------------
>
>                 Key: OLTU-78
>                 URL: https://issues.apache.org/jira/browse/OLTU-78
>             Project: Apache Oltu
>          Issue Type: Sub-task
>          Components: jwt
>            Reporter: Suresh Attanayake
>            Assignee: Antonio Sanso
>         Attachments: AMBER-80.patch, OLTU-78.patch, 
> support-for-public_and_private_claims-OLTU-78.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to