[ 
https://issues.apache.org/jira/browse/OLTU-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13909474#comment-13909474
 ] 

Simone Tripodi commented on OLTU-134:
-------------------------------------

Thanks a lot [~splatch] for providing the patch!

I tried to apply it but without success, got the following errors:

{noformat}
$ patch -p0 < ~/Downloads/OLTU-134.patch 
patching file oauth-2.0/client/pom.xml
patching file oauth-2.0/dynamicreg-common/pom.xml
patching file oauth-2.0/resourceserver/pom.xml
patching file oauth-2.0/httpclient4/pom.xml
patching file oauth-2.0/common/pom.xml
patching file oauth-2.0/dynamicreg-server/pom.xml
patching file oauth-2.0/pom.xml
patching file oauth-2.0/dynamicreg-client/pom.xml
patching file oauth-2.0/resourceserver-filter/pom.xml
patching file oauth-2.0/jwt/pom.xml
patching file oauth-2.0/authzserver/pom.xml
patching file demos/pom.xml
patching file parent/pom.xml
Hunk #1 FAILED at 363.
1 out of 4 hunks FAILED -- saving rejects to file parent/pom.xml.rej
patching file openid-connect/pom.xml
patching file openid-connect/common/pom.xml
patching file openid-connect/client/pom.xml
patching file jose/pom.xml
Hunk #1 FAILED at 21.
1 out of 1 hunk FAILED -- saving rejects to file jose/pom.xml.rej
patching file jose/jws/pom.xml
Hunk #1 FAILED at 26.
1 out of 1 hunk FAILED -- saving rejects to file jose/jws/pom.xml.rej
patching file commons/encodedtoken/pom.xml
Hunk #1 FAILED at 26.
1 out of 1 hunk FAILED -- saving rejects to file 
commons/encodedtoken/pom.xml.rej
patching file commons/json/pom.xml
Hunk #1 FAILED at 26.
1 out of 1 hunk FAILED -- saving rejects to file commons/json/pom.xml.rej
patching file commons/pom.xml
Hunk #1 FAILED at 21.
1 out of 1 hunk FAILED -- saving rejects to file commons/pom.xml.rej
{noformat}

Can you kindly help me on having it be applied?

Many thanks in advance!

> Broken OSGi metadata
> --------------------
>
>                 Key: OLTU-134
>                 URL: https://issues.apache.org/jira/browse/OLTU-134
>             Project: Apache Oltu
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 0.31
>            Reporter: Ɓukasz Dywicki
>            Assignee: Simone Tripodi
>              Labels: osgi
>         Attachments: OLTU-134.patch, karaf oltu.png
>
>
> Currently Oltu uses maven-bundle-plugin to generate manifest entries and 
> maven jar plugin to add some extra headers. This approach is error prone 
> because same thing is done in two different places and OSGi headers may be 
> easily broken if there is no tests deploying these jars in framework.
> Switching packaging type to bundle allows to use only one place to generate 
> manifest entries, including also these custom, and adds validation phase in 
> build to verify if all headers are just fine.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to