[
https://issues.apache.org/jira/browse/OMID-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15293780#comment-15293780
]
Flavio Junqueira commented on OMID-28:
--------------------------------------
I'm not sure what you mean with a two +1 votes, but what I mean is this:
# A contributor proposes a patch, it doesn't matter if the contributor is also
a committer
# A committer reviews it and +1 it if the patch is acceptable.
# The committer who reviewed can merge after the +1 but can make a judgment
call to ask someone else to review it if the committer feels that another pair
of eyes is needed.
For example, in this jira, we've merged two changes without any other committer
expressing whether the change is acceptable or not. When someone proposes a
patch, that person is in the role of contributor, so it doesn't matter whether
the person is a committer or not. It is also important to give time for people
to review the changes, especially people outside your org and in a different
time zone.
> Missing NOTICE file
> -------------------
>
> Key: OMID-28
> URL: https://issues.apache.org/jira/browse/OMID-28
> Project: Apache Omid
> Issue Type: Bug
> Reporter: Flavio Junqueira
> Assignee: Igor Katkov
> Priority: Blocker
> Fix For: 0.8.2.0
>
> Attachments: I386f5fa20d2578dc87a9b1eb93441c9cea4eb06b.patch,
> OMID-28.patch
>
>
> According to this, we need a NOTICE file:
> http://www.apache.org/legal/src-headers.html#notice
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
