[ 
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336434#comment-15336434
 ] 

Francisco Perez-Sorrosal commented on OMID-44:
----------------------------------------------

When [~alangates] voted -1 on Jun 6 at 11:55 AM on the topic "re[VOTE] Omid 
release branch 0.8.2.0 RC3(6)" he mentioned this: 

"-1

All incubator releases must have a disclaimer.  See 
http://incubator.apache.org/guides/releasemanagement.html#notes-disclaimer

I found for files that still have Yahoo copyright headers:
./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java
./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java
./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java
./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java

If we need to keep these with the Yahoo header than I think we need to put in 
the NOTICE file that this code includes code developed at Yahoo.  If we just 
missed these then we should put the standard Apache header on them.  See 
http://incubator.apache.org/guides/releasemanagement.html#best-practice-license 
for details.

I haven’t finished this but sending now as I see Igor is closing the vote and 
moving it to the incubator list.

Alan. "

Someone at some point added those classes into Omid from the YCSB project 
(https://github.com/brianfrankcooper/YCSB/) and they have the follwoing header 
were Yahoo is referenced:

/**                                                                             
                                                                                
                   
 * Copyright (c) 2010 Yahoo! Inc. All rights reserved.                          
                                                                                
                   
 *                                                                              
                                                                                
                   
 * Licensed under the Apache License, Version 2.0 (the "License"); you          
                                                                                
                   
 * may not use this file except in compliance with the License. You             
                                                                                
                   
 * may obtain a copy of the License at                                          
                                                                                
                   
 *                                                                              
                                                                                
                   
 * http://www.apache.org/licenses/LICENSE-2.0                                   
                                                                                
                   
 *                                                                              
                                                                                
                   
 * Unless required by applicable law or agreed to in writing, software          
                                                                                
                   
 * distributed under the License is distributed on an "AS IS" BASIS,            
                                                                                
                   
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or              
                                                                                
                   
 * implied. See the License for the specific language governing                 
                                                                                
                   
 * permissions and limitations under the License. See accompanying              
                                                                                
                   
 * LICENSE file.                                                                
                                                                                
                   
 */

When we first open-sourced Omid in Github, the legal department told me to 
maintain those headers, so when I read Alan's response I though that I should 
add the reference to Yahoo in the NOTICE file. But maybe I misunderstood him.

> Add reference to Yahoo code in NOTICE file
> ------------------------------------------
>
>                 Key: OMID-44
>                 URL: https://issues.apache.org/jira/browse/OMID-44
>             Project: Apache Omid
>          Issue Type: Task
>    Affects Versions: 0.8.2.0
>            Reporter: Francisco Perez-Sorrosal
>            Assignee: Francisco Perez-Sorrosal
>              Labels: license, notice
>             Fix For: 0.8.2.0
>
>
> Some files were taken from ycsb so we need to say that in NOTICE file:
> ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java
> ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java
> ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java
> ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to