[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349522#comment-15349522 ]
Flavio Junqueira commented on OMID-44: -------------------------------------- Thanks for bringing this up [~jmclean]. There are two references for YCSB, in one notice file, there is a mention to a google dependency, while the second doesn't. As I understand, we aren't including such a reference, so we can omit it. For the YCSB2 reference you pointed, the notice file says: {noformat} ========================================================================= NOTICE file for use with, and corresponding to Section 4 of, the Apache License, Version 2.0, in this case for the YCSB project. ========================================================================= This product includes software developed by Yahoo! Inc. (www.yahoo.com) Copyright (c) 2010 Yahoo! Inc. All rights reserved. {noformat} Two clarification questions: # Should we include the original NOTICE.txt file along with the copied YCSB files (in the same folder)? # Should we have a path in the notice indicating where the files are in the source code? > Add reference to Yahoo code in NOTICE file > ------------------------------------------ > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task > Affects Versions: 0.8.2.0 > Reporter: Francisco Perez-Sorrosal > Assignee: Francisco Perez-Sorrosal > Labels: license, notice > Fix For: 0.8.2.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)