[
https://issues.apache.org/jira/browse/OMID-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108663#comment-16108663
]
ASF GitHub Bot commented on OMID-74:
------------------------------------
Github user ebortnik commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/13#discussion_r130549454
--- Diff:
hbase-client/src/main/java/org/apache/omid/transaction/TTable.java ---
@@ -346,11 +373,31 @@ public ResultScanner getScanner(Transaction tx, Scan
scan) throws IOException {
}
Map<Long, Long> commitCache = buildCommitCache(rawCells);
+ buildFamilyDeletionCache(rawCells, familyDeletionCache);
- for (Collection<Cell> columnCells :
groupCellsByColumnFilteringShadowCells(rawCells)) {
+ for (Collection<Cell> columnCells :
groupCellsByColumnFilteringShadowCellsAndFamilyDeletion(rawCells)) {
boolean snapshotValueFound = false;
Cell oldestCell = null;
for (Cell cell : columnCells) {
+ List<Cell> familyDeletionCells =
familyDeletionCache.get(Bytes.toString((cell.getRow())));
--- End diff --
Many loops and break, consider breaking to functions
> Efficient column family deletion in Row level conflict analysis
> ---------------------------------------------------------------
>
> Key: OMID-74
> URL: https://issues.apache.org/jira/browse/OMID-74
> Project: Apache Omid
> Issue Type: New Feature
> Reporter: Ohad Shacham
>
> The idea is to use a qualifier to denote that all the columns of a specific
> family were deleted.
> Current implementation reads from HBase the entire family and then writes a
> tombstone to each one of its cells. The new implementation does not need to
> perform the read and only writes the qualifier to denote that the family was
> deleted. This is true only for Row level conflict detection since in Cell
> level we need to read the cells and add these to the write set.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
