[
https://issues.apache.org/jira/browse/OMID-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354365#comment-16354365
]
ASF GitHub Bot commented on OMID-85:
------------------------------------
Github user ebortnikov commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/20#discussion_r166407100
--- Diff:
hbase-client/src/main/java/org/apache/omid/transaction/TTable.java ---
@@ -293,15 +293,11 @@ public void delete(Transaction tx, Delete delete)
throws IOException {
}
- /**
- * Transactional version of {@link HTableInterface#put(Put put)}
- *
- * @param put an instance of Put
- * @param tx an instance of transaction to be used
- * @throws IOException if a remote or network exception occurs.
- */
- public void put(Transaction tx, Put put) throws IOException {
+ interface UpdateMetaData {
--- End diff --
What is the scope of this interface? Why is it package-level?
> Autocommit
> ----------
>
> Key: OMID-85
> URL: https://issues.apache.org/jira/browse/OMID-85
> Project: Apache Omid
> Issue Type: Sub-task
> Reporter: Ohad Shacham
> Assignee: Ohad Shacham
> Priority: Major
>
> Writing directly to HBase using specific version marks the write as a write
> that was done by a specific transaction. However, due to lack of shadow
> cells, getting the commit timestamp of the transaction can be done only by
> access the commit table. The motivation of this feature is to add the shadow
> cells during the write and save the commit table access.
> This feature is required by Apache Phoenix that during index creation adds
> the data table's entries, appeared before creation, to the index. In this
> case, the version and the commit timestamp should be the fence id and
> therefore, a direct write to HBase with the addition of shadow cells is
> required.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
