Github user ebortnikov commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/19#discussion_r166405079
--- Diff:
hbase-client/src/main/java/org/apache/omid/transaction/HBaseTransaction.java ---
@@ -31,25 +31,31 @@
public class HBaseTransaction extends AbstractTransaction<HBaseCellId> {
private static final Logger LOG =
LoggerFactory.getLogger(HBaseTransaction.class);
- public HBaseTransaction(long transactionId, long epoch,
Set<HBaseCellId> writeSet, AbstractTransactionManager tm) {
- super(transactionId, epoch, writeSet, tm);
+ public HBaseTransaction(long transactionId, long epoch,
Set<HBaseCellId> writeSet, Set<HBaseCellId> conflictFreeWriteSet,
AbstractTransactionManager tm) {
+ super(transactionId, epoch, writeSet, conflictFreeWriteSet, tm);
}
- public HBaseTransaction(long transactionId, long readTimestamp,
VisibilityLevel visibilityLevel, long epoch, Set<HBaseCellId> writeSet,
AbstractTransactionManager tm) {
- super(transactionId, readTimestamp, visibilityLevel, epoch,
writeSet, tm);
+ public HBaseTransaction(long transactionId, long readTimestamp,
VisibilityLevel visibilityLevel, long epoch, Set<HBaseCellId> writeSet,
Set<HBaseCellId> conflictFreeWriteSet, AbstractTransactionManager tm) {
+ super(transactionId, readTimestamp, visibilityLevel, epoch,
writeSet, conflictFreeWriteSet, tm);
}
+ private void cleanCell(HBaseCellId cell) {
--- End diff --
cleanCell --> deleteCell?
---