Thanks Alan. I'll start a vote in incubator. On Wed, Mar 21, 2018 at 9:46 PM, Alan Gates <alanfga...@gmail.com> wrote:
> +1. Checked DISCLAIMER, LICENSE, and NOTICE files, did a rat build, > checked that there weren't any binaries in the release. > > One note for future releases, Apache has now changed its guidelines on > hashes for the releases. It now recommends against md5 and requires SHA > (256 or greater I think). I don't think you need to reroll this release, > but it should be changed in the next release. > > Alan. > > On Sun, Mar 18, 2018 at 1:03 AM, Ohad Shacham <oh...@oath.com.invalid> > wrote: > > > Thanks James and Flavio. I will take your comments into account. > > According to https://www.apache.org/foundation/voting.htmlwe need at > > least three PMC members to vote and currently only two did. > > Could another PMC member please check the release and vote? > > Thanks,Ohad > > > > On Friday, March 16, 2018, 2:09:53 PM GMT+2, Flavio Junqueira < > > f...@apache.org> wrote: > > > > +1, I built from sources and built fine for me. I checked LICENSE and > > NOTICE, and ran the rat tool. > > > > One point that I'm wondering about is whether there has been an > > investigation of the dependencies with respect to licenses. It called my > > attention that both LICENSE and NOTICE files are pretty bare-bones. If > you > > haven't, it is worth going through this exercise and checking this page: > > > > http://www.apache.org/dev/licensing-howto.html < > http://www.apache.org/dev/ > > licensing-howto.html> > > > > -Flavio > > > > > On 14 Mar 2018, at 18:35, James Taylor <jamestay...@apache.org> wrote: > > > > > > +1 to the release. All unit tests pass with both "mvn package > -Dhbase-1" > > > and "mvn package -Dhbase-0" > > > > > > Some minor nits to consider for next time: > > > - have a default profile so that mvn package works out of the box > > > - separate integration tests (that require spinning up a mini cluster) > > from > > > other faster running tests. Run the faster unit tests during mvn > package > > > and run integration tests during mvn verify. > > > - put newlines in your email so that the URLs can be clicked on. > > Instead, > > > the URLs are running together with the next line. > > > > > > Thanks, > > > James > > > > > > On Tue, Mar 13, 2018 at 12:46 PM, Ohad Shacham <oh...@oath.com.invalid > > > > > wrote: > > > > > >> Add -Phbase-1 to your maven command. It should solve the error. > > >> > > >> > > >> Sent from Yahoo Mail for iPhone > > >> > > >> > > >> On Tuesday, March 13, 2018, 21:43, James Taylor < > jamestay...@apache.org > > > > > >> wrote: > > >> > > >> Rat check passes when I run "mvn -Prelease_profile -Phbase-1 install" > > which > > >> is good. > > >> > > >> However, "mvn clean install" fails (on my Mac) with the following > error: > > >> > > >> [INFO] > > >> ------------------------------------------------------------ > > ------------ > > >> [INFO] Building HBase tools 0.9.0.0 > > >> [INFO] > > >> ------------------------------------------------------------ > > ------------ > > >> [INFO] > > >> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ > > omid-hbase-tools > > >> --- > > >> [INFO] Deleting > > >> /Users/jtaylor/dev/apache/apache-omid-incubating-0.9.0. > > >> 0-src/hbase-tools/target > > >> [INFO] > > >> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ > > >> omid-hbase-tools --- > > >> [INFO] Using 'UTF-8' encoding to copy filtered resources. > > >> [INFO] skip non existing resourceDirectory > > >> /Users/jtaylor/dev/apache/apache-omid-incubating-0.9.0. > > >> 0-src/hbase-tools/src/main/resources > > >> [INFO] > > >> [INFO] --- maven-compiler-plugin:3.5:compile (default-compile) @ > > >> omid-hbase-tools --- > > >> [INFO] Changes detected - recompiling the module! > > >> [INFO] Compiling 1 source file to > > >> /Users/jtaylor/dev/apache/apache-omid-incubating-0.9.0. > > >> 0-src/hbase-tools/target/classes > > >> [INFO] ------------------------------------------------------------- > > >> [ERROR] COMPILATION ERROR : > > >> [INFO] ------------------------------------------------------------- > > >> [ERROR] > > >> /Users/jtaylor/dev/apache/apache-omid-incubating-0.9.0. > > >> 0-src/hbase-tools/src/main/java/org/apache/omid/tools/ > > >> hbase/OmidTableManager.java:[33,23] > > >> cannot find symbol > > >> symbol: class HBaseShims > > >> location: package org.apache.omid > > >> [ERROR] > > >> /Users/jtaylor/dev/apache/apache-omid-incubating-0.9.0. > > >> 0-src/hbase-tools/src/main/java/org/apache/omid/tools/ > > >> hbase/OmidTableManager.java:[153,13] > > >> cannot find symbol > > >> symbol: variable HBaseShims > > >> location: class org.apache.omid.tools.hbase.OmidTableManager > > >> [INFO] 2 errors > > >> > > >> > > >> On Tue, Mar 13, 2018 at 2:17 AM, Ohad Shacham <oh...@oath.com.invalid > > > > >> wrote: > > >> > > >>> Hi All, > > >>> > > >>> I would like to call a vote to release Apache Omid (Incubator) > 0.9.0.0, > > >>> release candidate #1. > > >>> Links to various release artifacts are given below. Please review and > > >> vote. > > >>> > > >>> The vote will be open for at least 72 hours and until necessary > number > > of > > >>> votes are reached. > > >>> [ ] +1 approve > > >>> [ ] +0 no opinion > > >>> [ ] -1 disapprove (and reason why) > > >>> > > >>> Here is my +1 > > >>> > > >>> Release notes for the 0.9.0.0 release: > > >>> https://dist.apache.org/repos/dist/dev/incubator/omid/0.9.0. > > >>> 0-rc1/RELEASE_NOTES.html > > >>> > > >>> Git tag for the release:https://git-wip-us.apache.org/repos/asf/ > > >>> incubator-omid.git/?p=incubator-omid.git;a=tag;h= > > >>> 5dd5f86822beb43d08e91d00dd2427b4f130d6c2 > > >>> > > >>> Sources for the release:https://dist.apache. > > >> org/repos/dist/dev/incubator/ > > >>> omid/0.9.0.0-rc1/apache-omid-incubating-0.9.0.0-src.tar.gzSource > > release > > >>> verification: PGP Signature: https://dist.apache.org/repos/ > > >>> dist/dev/incubator/omid/0.9.0.0-rc1/apache-omid-incubating- > > >>> 0.9.0.0-src.tar.gz.ascMD5 Hash: https://dist.apache.org/repos/ > > >>> dist/dev/incubator/omid/0.9.0.0-rc1/apache-omid-incubating- > > >>> 0.9.0.0-src.tar.gz.md5Keys to verify the signature of the release > > >>> artifact are available at:https://dist.apache.org/ > > >>> repos/dist/dev/incubator/omid/0.9.0.0-rc1/KEYS > > >>> Thanks,Ohad > > >> > > >> > > >> > > >> > > > > >
