[ 
https://issues.apache.org/jira/browse/OMID-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590299#comment-16590299
 ] 

James Taylor commented on OMID-107:
-----------------------------------

Thanks, [~yonigo], but my question is specifically around this test: 
TestBaillisAnomaliesWithTXs.testSIPreventsReadSkewUsingWritePredicate(). Why is 
it expected that the commit at the end of the test will fail?

The HBase 0.x releases have been end-of-life for a long time. Phoenix is no 
longer doing releases that support them (nor is any other project I'm aware 
of). The changes are compatible with HBase 1.x and HBase 2.x releases.

There's no infinite loop in the changes I've made. I changed 
AttributeSetSnapshotFilter to go through TTable abstraction instead of 
HTableInterface because the autoFlush (i.e. buffering) of HTableInterface is no 
longer available in the Table interface. It's trivial to implement it, though, 
so I put that functionality in TTable and moved abstractions that were using it 
from HTableInterface to TTable.

> Replace HTableInterface with Table
> ----------------------------------
>
>                 Key: OMID-107
>                 URL: https://issues.apache.org/jira/browse/OMID-107
>             Project: Apache Omid
>          Issue Type: Sub-task
>            Reporter: James Taylor
>            Priority: Major
>         Attachments: OMID-107.patch
>
>
> In HBase 2.0, the HTableInterface has been replaced with the Table interface. 
> Thus, in Omid, this same replacement should take place. This will mostly be 
> isolated to having TTable implement Table instead of HTableInterface. This 
> will be required to check-in Omid support in Phoenix, since Phoenix 5.x is 
> based on HBase 2.0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to