[
https://issues.apache.org/jira/browse/OMID-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635682#comment-16635682
]
James Taylor commented on OMID-114:
-----------------------------------
{quote}Why in the case of deletes we check deleteP.isEmpty() but we dont do it
for puts?
{quote}
I wanted to keep the same checks that were in place before my change. For
delete, there's a possibility for the Put to not contain anything - in the case
that the entire row is deleted and the Get doesn't find the row. Phoenix would
never hit this case as it always does a family delete. For the puts case, the
put can never be empty.
> Prevent extra RPCs on TTable batch operations
> ---------------------------------------------
>
> Key: OMID-114
> URL: https://issues.apache.org/jira/browse/OMID-114
> Project: Apache Omid
> Issue Type: Sub-task
> Reporter: James Taylor
> Priority: Major
> Attachments: OMID-114.patch, OMID-114_v2.patch
>
>
> We're doing an RPC for every item in batch operations on these TTable method:
> * put(Transaction transaction, List<Put> puts)
> * delete(Transaction transaction, List<Delete> deletes)
> * batch(Transaction transaction, List<? extends Row> rows)
> Instead, we can do a single RPC when the rows are sent to HBase.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
