[
https://issues.apache.org/jira/browse/OMID-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649272#comment-16649272
]
Yonatan Gottesman commented on OMID-117:
----------------------------------------
Hi when i run mvn clean install -Phbase-1 I get tests failing on
hbase-coprocessor module. Do you manage to run it ok?
Regarding what you said:
{code:java}
I had to move the RPC controller classes into hbase-shim because the base
classes were renamed between hbase 1.x and 2.x
{code}
I had the same issue with the coprocessors extending BaseRegionObserver. In
Hbase2 there is no class so i created this class in hbase2-shims that extended
the correct class.
So you can do the same thing to avoid code duplication:
put InterRegionServerRpcController back in coprocessor and have only one copy.
make InterRegionServerRpcController extend DelegatingHBaseRpcController (hbase2
version)
in hbase1-shims create class DelegatingPayloadCarryingRpcController and make it
extend DelegatingPayloadCarryingRpcController.
What do you think?
> Ensure timeouts are configured low for RPCs to commit table
> -----------------------------------------------------------
>
> Key: OMID-117
> URL: https://issues.apache.org/jira/browse/OMID-117
> Project: Apache Omid
> Issue Type: Bug
> Reporter: James Taylor
> Priority: Major
> Attachments: OMID-117.patch, OMID-117_v2.patch, OMID-117_v3.patch,
> OMID-117_v4.patch, OMID-117_v5.patch, OMID-117_v6.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
