On a second look, it looks like there's some incompatibility for omid2 and phoenix-queryserver, so I'm going to have to change my vote to -1 until we investigate (hopefully it's a phoenix issue). The phoenix-queryserver tests are passing on the 4.x-HBase-1.3 branch: https://builds.apache.org/job/Phoenix-4.x-HBase-1.3/266/ while they are failing for the omid2 branch: https://builds.apache.org/job/Phoenix-omid2/155/ with the following error:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on project phoenix-queryserver: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.20:test failed: java.lang.UnsupportedClassVersionError: org/apache/calcite/avatica/server/HttpServer$Builder : Unsupported major.minor version 52.0 -> [Help 1] According to this ( https://stackoverflow.com/questions/22489398/unsupported-major-minor-version-52-0) stack overflow thread, there's an issue between different JDK versions. The omid2 branch is caught up to the 4.x-HBase-1.3 branch with only the omid related changes (https://github.com/apache/phoenix/pull/305), so I think we need to take a look at this before proceeding. Thanks, James On Fri, Nov 16, 2018 at 10:50 AM James Taylor <jamestay...@apache.org> wrote: > +1. Verified that all unit tests are consistently passing on the Phoenix > omid2 branch. > > On Fri, Nov 16, 2018 at 2:14 AM Yoni Gottesman <yonig...@gmail.com> wrote: > >> +1 >> >> On Fri, Nov 16, 2018 at 1:01 AM Francisco Perez-Sorrosal >> <fpe...@oath.com.invalid> wrote: >> >> > +1 >> > On Thursday, November 15, 2018, 12:32:40 AM PST, Ohad Shacham >> > <oh...@oath.com.INVALID> wrote: >> > >> > Hi All, >> > >> > >> > We would like to call a vote to release Apache Omid (Incubator) 1.0.0, >> > release candidate #0. >> > >> > >> > Links to various release artifacts are given below. Please review and >> vote. >> > >> > The vote will be open for at least 72 hours and until necessary number >> of >> > votes are reached. >> > [ ] +1 approve >> > [ ] +0 no opinion >> > [ ] -1 disapprove (and reason why) >> > >> > Here is my +1 >> > >> > Release notes for the 1.0.0 >> > release: >> > >> https://dist.apache.org/repos/dist/dev/incubator/omid/1.0.0-rc0/RELEASE_NOTES.html >> > >> > Git tag for the release: >> > >> > >> > >> https://git-wip-us.apache.org/repos/asf/incubator-omid.git/?p=incubator-omid.git;a=tag;h=14d5cb2d899ef381be40edc6d95aede50bb396ea >> > >> > >> > Sources for the release: >> > >> > >> > >> https://dist.apache.org/repos/dist/dev/incubator/omid/1.0.0-rc0/apache-omid-incubating-1.0.0-src.tar.gz >> > Source release verification: PGP Signature: >> > >> > >> https://dist.apache.org/repos/dist/dev/incubator/omid/1.0.0-rc0/apache-omid-incubating-1.0.0-src.tar.gz.asc >> > SHA512 >> > < >> https://dist.apache.org/repos/dist/dev/incubator/omid/1.0.0-rc0/apache-omid-incubating-1.0.0-src.tar.gz.ascSHA512 >> > >> > Hash: >> > >> > >> https://dist.apache.org/repos/dist/dev/incubator/omid/1.0.0-rc0/apache-omid-incubating-1.0.0-src.tar.gz.sha512 >> > Keys to verify the signature of the release artifact are available at: >> > https://dist.apache.org/repos/dist/dev/incubator/omid/1.0.0-rc0/KEYS >> > >> > >> > Thanks, >> > Yoni and Ohad >> > >> >
