[
https://issues.apache.org/jira/browse/OMID-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730662#comment-16730662
]
Lars Hofhansl edited comment on OMID-124 at 12/29/18 12:21 PM:
---------------------------------------------------------------
I see. Either way it fine. Daemon thread is fine if the thread should simply go
away when the JVM shuts down, if some cleanup needs to be (even on JVM
shutdown) then requiring the application to close is better.
(It's not low-priority, just a thread that won't stop the JVM from closing.
Almost all HBase chore threads are daemon threads, so that the region server
can stop.)
was (Author: lhofhansl):
I see. Either way it fine. Daemon thread is fine if the thread should simply go
away when the JVM shuts down, if some cleanup needs to be (even on JVM
shutdown) then requiring the application to close is better.
> HBaseCommitTable.HBaseClient.deleteBatchExecutor should use daemon threads
> --------------------------------------------------------------------------
>
> Key: OMID-124
> URL: https://issues.apache.org/jira/browse/OMID-124
> Project: Apache Omid
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Yonatan Gottesman
> Priority: Major
> Attachments: OMID-124.txt
>
>
> I found that as soon as any transaction is written in HBase, the region
> server subsequently fails to shut down.
> I tracked it down the HBaseClient in HBaseCommitTable. I think this should
> generally create daemon threads only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
