GitHub user plaflamme opened a pull request:
https://github.com/apache/incubator-omid/pull/54
TIDY: Safe shutdown
This prevents an exception thrown in one service to prevent others to
shutdown safely.
NOTE: this is theoretical since I haven't observed this particular problem
in practice. `Closeable` are allowed to throw during execution, so in theory
this can happen and would likely lead to dangling threads that would prevent
the JVM from shutting down. Adding these safeguards makes the shutdown process
best-effort.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/plaflamme/incubator-omid tidy-safe-shutdown
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-omid/pull/54.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #54
----
commit 5a8be54bfaad63a798d8109cf97be82e80e5474d
Author: Philippe Laflamme <plaflamme@...>
Date: 2018-12-31T17:08:42Z
TIDY: Safe shutdown
This prevents an exception thrown in one service to prevent others to
shutdown safely.
----
---
