yonigottesman commented on a change in pull request #58: [OMID-134] - transactionManager is thread safe. URL: https://github.com/apache/incubator-omid/pull/58#discussion_r261129390
########## File path: hbase-common/src/main/java/org/apache/omid/transaction/CellUtils.java ########## @@ -328,15 +347,20 @@ public static Cell buildShadowCellFromCell(Cell cell, byte[] shadowCellValue) { } } else { cellIdToCellMap.put(key, cell); - cellToShadowCellMap.put(cell, Optional.<Cell>absent()); + Cell sc = cellIdToSCCellMap.get(key); Review comment: must support MVCC ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services