[
https://issues.apache.org/jira/browse/OMID-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829582#comment-16829582
]
Lars Hofhansl commented on OMID-146:
------------------------------------
Here's the diff for the nit.
I see you added me as committer. Happy to make this my first commit. :)
There's no functional change.
{code}
diff --git
a/hbase-common/src/main/java/org/apache/omid/transaction/CellUtils.java
b/hbase-common/src/main/java/org/apache/omid/transaction/CellUtils.java
index 575c3be..c5a291e 100644
--- a/hbase-common/src/main/java/org/apache/omid/transaction/CellUtils.java
+++ b/hbase-common/src/main/java/org/apache/omid/transaction/CellUtils.java
@@ -329,9 +329,9 @@ public final class CellUtils {
for (Cell cell : cells) {
if (!isShadowCell(cell)) {
CellId key = new CellId(cell, false);
- if (cellIdToCellMap.containsKey(key)) {
- // Get the current cell and compare the values
- Cell storedCell = cellIdToCellMap.get(key);
+ // Get the current cell and compare the values
+ Cell storedCell = cellIdToCellMap.get(key);
+ if (storedCell != null) {
if (CellUtil.matchingValue(cell, storedCell)) {
// TODO: Should we check also here the MVCC and swap if its greater???
// Values are the same, ignore
{code}
> Persist transaction commit before updating low watermark
> --------------------------------------------------------
>
> Key: OMID-146
> URL: https://issues.apache.org/jira/browse/OMID-146
> Project: Apache Omid
> Issue Type: Bug
> Reporter: Ohad Shacham
> Assignee: Yonatan Gottesman
> Priority: Minor
> Fix For: 1.0.1
>
> Attachments: screenshot-1.png
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> When a transaction t updates the conflict table at the TSO, it mights remove
> entries of transactions that committed after t started, or even entries of t.
> Therefore, in order to make sure that the garbage collector does not removes
> entries of t from the data tables, thinking accidentally that t was not
> committed yet. We should first persist t's commit in the commit table and
> only then update the low watermark. This also applies to the low latency
> which persists the commit by the clients.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
