[ https://issues.apache.org/jira/browse/ONAMI-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Mazursky closed ONAMI-88. --------------------------------- > Consistent policy for exception handling > ---------------------------------------- > > Key: ONAMI-88 > URL: https://issues.apache.org/jira/browse/ONAMI-88 > Project: Apache Onami > Issue Type: Improvement > Components: configuration > Affects Versions: configuration-6.3.0 > Reporter: Mikhail Mazursky > Assignee: Mikhail Mazursky > Priority: Minor > Fix For: configuration-6.3.0 > > > No consistent policy for exception handling - for example > SQLTimestampConverter catches Throwable and rethrows it as ProvisionException > but CharsetConverter do not catch anything at all. Should we catch at all or > Guice handles this itself? > I guess we should rethrow only checked exceptions. Also no need to catch > Errors in such places in any case (catch Exception vs Throwable). -- This message was sent by Atlassian JIRA (v6.1.5#6160)