[
https://issues.apache.org/jira/browse/ONAMI-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Mazursky closed ONAMI-91.
---------------------------------
> Refactor TestConcurrentLazySingleton test
> -----------------------------------------
>
> Key: ONAMI-91
> URL: https://issues.apache.org/jira/browse/ONAMI-91
> Project: Apache Onami
> Issue Type: Improvement
> Components: scopes
> Affects Versions: scopes-1.0.0
> Reporter: Mikhail Mazursky
> Assignee: Jordan Zimmerman
> Priority: Minor
> Fix For: scopes-1.0.0
>
>
> - test with Executors.newSingleThreadExecutor() should shutdown the executor
> in a finally block to avoid preventing JVM termination by active thread;
> - In the same test you can just wait on Future returned by executor;
> - I think it's better to always set timeout for waiting in such cases in
> tests - like 1 minute. Just to avoid locking JVM in case of some bug in test.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
