Hi Mikhail! :)
> > Looks like you are talking about ONAMI-102. I'm not sure what to do about > it. I think I forgot what the current API looks like :) So I need to try to > use it in real application and see what improvements I can propose. BTW the > first mention about changing this is in ONAMI-45, where the functionality > was introduced. > > yes IIRC looks like I referred to ONAMI-102; shortly, I'd rather have, since the first release, a Lifecycle Modules API that looks like a properer Guice module, where only a `configureLifecycle()` (or something similar) and a small EDSL to make the binding, rather than having Modules with multiple constructors and builder patterns. Just have a look at how other released modules look like. > Assuming you are talking about com.google.inject.internal package usage, I > fixed couple of places but there is still one place > (org.apache.onami.scopes.ConcurrentLazySingletonScopeImpl) where it is > used. The mentioned usage can be reimplemented by using class object > inspection instead of directly doing instanceOf check. Any better ideas? > > nope sorry I should have a deep look on that :( Please apologise :( > > * Guice 4.0-beta has been released time ago - we need definitively be > > prepared to integrate it :) > > > > I don't think that will be an issue. Probably some people wait for 4.0 > release but we can bump to -beta - I do not have any objections here. > > OK thanks a lot :) > > > > > > What do you think? > > > > > > > let's try to find some more spare time and keep the rock rolling :) > > > > Sounds great! :) > > Kind regards, > Mikhail. > All the best, have a nice weekend! -Simo http://people.apache.org/~simonetripodi/ http://twitter.com/simonetripodi
