+1 for using standard JSR330 types and annotations (where possible)
On 15 Oct 2014 21:18, "Stephan Classen" <sclas...@apache.org> wrote: > > I found that in onami-persist both javax.inject.Inject and com.google.inject.Injector were used. The same held for Provider. When I wrote the code I didn't pay any attention to the imports as long as all tests passed. > Yesterday I replaced all imports of javax.inject.Inject with imports of com.google.inject.Injector. I couldn't find any best practice recommendation and since we do have a dependency on guice I went with the classes in the com.google.inject package. > > Now Mikhail questions my decision and I must admit that his reasoning makes sense. Are there any other opinions? > > If not I would suggest that we should use classes from javax.inject whenever possible. > > Greets > Stephan > > Am 15.10.2014 02:05 schrieb Mikhail Mazursky <mikhail.mazur...@gmail.com>: > > Hello Stephan, > > Don't you think we better use javax.inject.* classes when available? > Just curious why you did that change. IMHO it is always better to > give preference to standard annotations/interfaces when available. I > know we a coupled with Guice as we write extensions for it but in an > ideal world Guice would not have proprietary annotations/interfaces > at all so they may drop/deprecate them some day. > > Cheers, > Mikhail.
