Hi Mikhail, like for the new proposed component on JIRA: could you please fill an issue for each action you detected on the [configuration] component?
TIA, -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Thu, Feb 21, 2013 at 1:25 PM, Mikhail Mazursky <mikhail.mazur...@gmail.com> wrote: > +1 to graduate but there are lots of minor things to work on: > > - No consistent policy for exception handling - for example > SQLTimestampConverter catches Throwable and rethrows it as > ProvisionException but CharsetConverter do not catch anything at all. > Should we catch at all or Guice handles this itself? > - No need to catch Errors in such places in any case (catch Exception is > enough IMHO); > - PropertiesConverter converts String to bytes using ISO-8859-1 and then > uses Properties.load() which converts that back to chars. Maybe just use > Properties.load(new StringReader(value))? Someone already handled encoding > problems and passed String to Guice so why mess with it one more time? > - DateConverter is mutable - this is a bad idea itself IMHO but also there > is no clean way to set locale and timezone. Maybe there is room for a > simple DSL or builder for that module. > > Hope that helps =) >
