Got it!
OK, then can we change the name to something more meaningful then, like how
about:
{code:java}
public void retrieveProduct(Product product, File localDirectory) throws
DataTransferException, IOException
{code}
Realize too, that if this method sits at the XmlRpcFileManager level, it only
needs to be written one time, as opposed to 3-4 right now if it's in the
DataTransfer impls right now. The only bad part about that is that I agree with
you +1 that this method is definitely unique to the transfers themselves, so
probably belongs there (it's like the reply part of request/reply).
Looks good!
Cheers,
Chris
On Dec 13, 2010, at 11:24 PM, Brian Foster (JIRA) wrote:
>
> [
> https://issues.apache.org/jira/browse/OODT-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971185#action_12971185
> ]
>
> Brian Foster commented on OODT-84:
> ----------------------------------
>
>
> - the DataTransfer is what is used to move the file into the archive,
> therefore i think it should be the one to copy the file back out of the
> archive . . . for example, say the files are being store at Amazon S3, if a
> S3DataTransfer was written it could then be used to both ingest and retrieve
> the file, otherwise you would only be able to ingest the file (retrieval
> would not work in those cases)
>
>> Ability for File Manager to stage an ingested Product to one of its clients
>> ---------------------------------------------------------------------------
>>
>> Key: OODT-84
>> URL: https://issues.apache.org/jira/browse/OODT-84
>> Project: OODT
>> Issue Type: New Feature
>> Components: file manager
>> Affects Versions: 0.1-incubating
>> Environment: none
>> Reporter: Brian Foster
>> Assignee: Brian Foster
>> Priority: Minor
>> Fix For: 0.2
>>
>>
>> - This patch will introduce the following method to DataTransfer:
>> {noformat}
>> /**
>> * Requires that the data store reference be set, nothing else is used
>> * @param product The product whose data store reference will be copied
>> * @param directory The directory where the data store reference will
>> be copied to
>> * @throws DataTransferException
>> * If a general error occurs during the transfer.
>> * @throws IOException
>> * If there is an IO error when performing the transfer.
>> */
>> public void copyProduct(Product product, File directory) throws
>> DataTransferException,
>> IOException;
>> {noformat}
>> - There will also be a new File Manager client command line option
>> introduced:
>> {noformat}
>> --copyProduct (--productId <id> | --productName <name>) --destPath
>> <directory> [--transferer <factory-class>]
>> {noformat}
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Email: [email protected]
WWW: http://sunset.usc.edu/~mattmann/
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Adjunct Assistant Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
