----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2638/#review2938 -----------------------------------------------------------
Amazing! Only comment that I have is to change 0.3-SNAPSHOT in the pom.xml to 0.4-SNAPSHOT. - Chris On 2011-10-31 01:09:17, brian Foster wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2638/ > ----------------------------------------------------------- > > (Updated 2011-10-31 01:09:17) > > > Review request for oodt and Chris Mattmann. > > > Summary > ------- > > CAS-CL will be initally just moved to trunk, then will be added to components > 1 by 1 after that > > > Diffs > ----- > > https://svn.apache.org/repos/asf/oodt/trunk/cl/pom.xml PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/CmdLineArgs.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/CmdLineUtility.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/action/CmdLineAction.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/action/PrintMessageAction.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/action/store/CmdLineActionStore.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/action/store/CmdLineActionStoreFactory.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/action/store/spring/SpringCmdLineActionStore.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/action/store/spring/SpringCmdLineActionStoreFactory.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/action/store/spring/SpringSetContextInjectionType.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/help/OptionHelpException.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/help/presenter/CmdLineOptionHelpPresenter.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/help/presenter/StdCmdLineOptionHelpPresenter.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/help/printer/CmdLineActionHelpPrinter.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/help/printer/CmdLineActionsHelpPrinter.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/help/printer/CmdLineOptionsHelpPrinter.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/help/printer/StdCmdLineActionHelpPrinter.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/help/printer/StdCmdLineActionsHelpPrinter.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/help/printer/StdCmdLineOptionsHelpPrinter.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/ActionCmdLineOption.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/AdvancedCmdLineOption.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/CmdLineOption.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/CmdLineOptionInstance.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/GroupCmdLineOption.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/HandleableCmdLineOption.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/HelpCmdLineOption.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/PrintSupportedActionsCmdLineOption.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/SimpleCmdLineOption.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/ValidatableCmdLineOption.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/handler/ApplyToAction.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/handler/ApplyToActionHandler.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/handler/CmdLineOptionHandler.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/require/ActionDependencyRule.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/require/RequirementRule.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/store/CmdLineOptionStore.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/store/CmdLineOptionStoreFactory.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/store/spring/SpringCmdLineOptionStore.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/store/spring/SpringCmdLineOptionStoreFactory.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/validator/AllowedArgsCmdLineOptionValidator.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/validator/ArgRegExpCmdLineOptionValidator.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/validator/ClassExistsCmdLineOptionValidator.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/validator/CmdLineOptionValidator.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/validator/FileExistCmdLineOptionValidator.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/option/validator/NoRestrictionsCmdLineOptionValidator.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/parser/CmdLineOptionParser.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/parser/StdCmdLineOptionParser.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/util/Args.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/main/java/org/apache/oodt/cas/cl/util/CmdLineUtils.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/test/org/apache/oodt/cas/cl/TestCmdLineArgs.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/test/org/apache/oodt/cas/cl/action/store/spring/TestSpringCmdLineActionStore.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/test/org/apache/oodt/cas/cl/option/handler/TestApplyToAction.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/test/org/apache/oodt/cas/cl/option/handler/TestApplyToActionHandler.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/test/org/apache/oodt/cas/cl/option/require/TestActionDependencyRule.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/test/org/apache/oodt/cas/cl/option/store/spring/TestSpringCmdLineOptionStore.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/test/org/apache/oodt/cas/cl/option/validator/TestAllowedArgsCmdLineOptionValidator.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/test/org/apache/oodt/cas/cl/option/validator/TestArgRegExpCmdLineOptionValidator.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/test/org/apache/oodt/cas/cl/option/validator/TestClassExistsCmdLineOptionValidator.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/test/org/apache/oodt/cas/cl/option/validator/TestFileExistCmdLineOptionValidator.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/test/org/apache/oodt/cas/cl/option/validator/TestNoRestrictionsCmdLineOptionValidator.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/test/org/apache/oodt/cas/cl/parser/TestStdCmdLineOptionParser.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/test/org/apache/oodt/cas/cl/test/util/TestOutputStream.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/test/org/apache/oodt/cas/cl/test/util/TestSetContextInjectTypeAction.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/test/org/apache/oodt/cas/cl/test/util/TestUtils.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/test/org/apache/oodt/cas/cl/util/TestArgs.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/test/org/apache/oodt/cas/cl/util/TestCmdLineUtils.java > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/testdata/cmd-line-actions.xml > PRE-CREATION > > https://svn.apache.org/repos/asf/oodt/trunk/cl/src/testdata/cmd-line-options.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/2638/diff > > > Testing > ------- > > Many unit-tests > > > Thanks, > > brian > >
