I'll create a separate issue after I check this current issue in... this issues 
will change fm, wm, and rm actions to match their option long name

-brian

On Nov 29, 2011, at 1:09 PM, "Ramirez, Paul M (388J)" 
<[email protected]> wrote:

> Hey Brian,
> 
> That sounds like the perfect balance to make the psa and op align better.
> 
> Thanks,
> Paul
> 
> On Nov 28, 2011, at 9:38 AM, brian Foster wrote:
> 
> This is an automatically generated e-mail. To reply, visit: 
> https://reviews.apache.org/r/2946/
> 
> 
> On November 28th, 2011, 4:49 p.m., Paul Ramirez wrote:
> 
> Looks good. The only comment I have is there seems to be a mismatch in the 
> -psa and the action names that get listed and the operations that can be 
> triggered. Seems like there may need to be a mapping there. When you look up 
> help on an action you use the ActionName. When you do an operation its by its 
> flag. Although there is seemingly a one to one mapping the command line 
> arguments don't seem interchangeable.
> 
> when you use -h <action> it tells you which command line flags to use... we 
> can change the name of the actions to start lowercased like the flag if you 
> think that will get rid of some confusion
> 
> 
> - brian
> 
> 
> On November 28th, 2011, 8:43 a.m., brian Foster wrote:
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> By brian Foster.
> 
> Updated 2011-11-28 08:43:27
> 
> Description
> 
> Issue being tracked at: https://issues.apache.org/jira/browse/OODT-351
> 
> Added command-line options for filemgr:
> 
> $ ./filemgr-client -h
> -----------------------------------------------------------------------------------------------------------------
> | Short | Long                                             | Description
> -----------------------------------------------------------------------------------------------------------------
> 
> -op,    --operation                                        Declare that you 
> wish to present an operation
>   SubOptions:
>> Required:
>> Optional:
>      -addPT, --addProductType                              Triggers 
> AddProductType Action
>                                                              Requirement 
> Rules:
>                                                               [AddProductType 
> : REQUIRED]
>      -dbyid, --deleteProductById                           Triggers 
> DeleteProductById Action
>                                                              Requirement 
> Rules:
>                                                               
> [DeleteProductById : REQUIRED]
>      -dbyn,  --deleteProductByName                         Triggers 
> DeleteProductByName Action
>                                                              Requirement 
> Rules:
>                                                               
> [DeleteProductByName : REQUIRED]
>      -ingest,--ingestProduct                               Triggers 
> IngestProduct Action
>                                                              Requirement 
> Rules:
>                                                               [IngestProduct 
> : REQUIRED]
>      -product,--hasProduct                                  Triggers 
> HasProduct Action
>                                                              Requirement 
> Rules:
>                                                               [HasProduct : 
> REQUIRED]
>      -ptbyn, --getProductTypeByName                        Triggers 
> GetProductTypeByName Action
>                                                              Requirement 
> Rules:
>                                                               
> [GetProductTypeByName : REQUIRED]
>      -num,   --getNumProducts                              Triggers 
> GetNumProducts Action
>                                                              Requirement 
> Rules:
>                                                               [GetNumProducts 
> : REQUIRED]
>      -page1, --getFirstPage                                Triggers 
> GetFirstPage Action
>                                                              Requirement 
> Rules:
>                                                               [GetFirstPage : 
> REQUIRED]
>      -next,  --getNextPage                                 Triggers 
> GetNextPage Action
>                                                              Requirement 
> Rules:
>                                                               [GetNextPage : 
> REQUIRED]
>      -prev,  --getPrevPage                                 Triggers 
> GetPrevPage Action
>                                                              Requirement 
> Rules:
>                                                               [GetPrevPage : 
> REQUIRED]
>      -last,  --getLastPage                                 Triggers 
> GetLastPage Action
>                                                              Requirement 
> Rules:
>                                                               [GetLastPage : 
> REQUIRED]
>      -curTran,--getCurrentTransfer                          Triggers 
> GetCurrentTransfer Action
>                                                              Requirement 
> Rules:
>                                                               
> [GetCurrentTransfer : REQUIRED]
>      -curTrans,--getCurrentTransfers                         Triggers 
> GetCurrentTransfers Action
>                                                              Requirement 
> Rules:
>                                                               
> [GetCurrentTransfers : REQUIRED]
>      -pbyid, --getProductById                              Triggers 
> GetProductById Action
>                                                              Requirement 
> Rules:
>                                                               [GetProductById 
> : REQUIRED]
>      -pbyn,  --getProductByName                            Triggers 
> GetProductByName Action
>                                                              Requirement 
> Rules:
>                                                               
> [GetProductByName : REQUIRED]
>      -pctTrans,--getProductPctTransferred                    Triggers 
> GetProductPercentTransferred Action
>                                                              Requirement 
> Rules:
>                                                               
> [GetProductPercentTransferred : REQUIRED]
>      -filePctTrans,--getFilePctTransferred                       Triggers 
> GetFilePercentTransferred Action
>                                                              Requirement 
> Rules:
>                                                               
> [GetFilePercentTransferred : REQUIRED]
>      -sql,   --sqlQuery                                    Triggers SqlQuery 
> Action
>                                                              Requirement 
> Rules:
>                                                               [SqlQuery : 
> REQUIRED]
> 
> -u,     --url <url>                                        Workflow Manager 
> URL
>                                                              Handler:
>                                                               Sets the 
> following Java Properties:
>                                                               
> [org.apache.oodt.cas.workflow.url]
> 
> -f,     --filter                                           Query filter
>                                                              Requirement 
> Rules:
>                                                               [SqlQuery : 
> OPTIONAL]
> 
>   SubOptions:
>> Required:
>      -algor, --algor <classpath>                           FilterAlgor class
>                                                              Requirement 
> Rules:
>                                                               [SqlQuery : 
> REQUIRED]
> 
>                                                              Handler:
>                                                               Will invoke 
> 'setAlgor' on action selected, except
>                                                               for the 
> following actions: []
>      -sdtMetKey,--startDateTimeMetKey <metadata-key>          Start date time 
> metadata key
>                                                              Requirement 
> Rules:
>                                                               [SqlQuery : 
> REQUIRED]
> 
>                                                              Handler:
>                                                               Will invoke 
> 'setStartDateTimeMetKey' on action
>                                                               selected, 
> except for the following actions: []
>      -edtMetKey,--endDateTimeMetKey <metadata-key>            End date time 
> metadata key
>                                                              Requirement 
> Rules:
>                                                               [SqlQuery : 
> REQUIRED]
> 
>                                                              Handler:
>                                                               Will invoke 
> 'setEndDateTimeMetKey' on action
>                                                               selected, 
> except for the following actions: []
>      -prMetKey,--priorityMetKey <metadata-key>               Priority 
> metadata key
>                                                              Requirement 
> Rules:
>                                                               [SqlQuery : 
> REQUIRED]
> 
>                                                              Handler:
>                                                               Will invoke 
> 'setPriorityMetKey' on action
>                                                               selected, 
> except for the following actions: []
>> Optional:
>      -conv,  --converter <classpath>                       VersionConverter 
> class
>                                                              Requirement 
> Rules:
>                                                               [SqlQuery : 
> OPTIONAL]
> 
>                                                              Handler:
>                                                               Will invoke 
> 'setConverter' on action selected,
>                                                               except for the 
> following actions: []
> 
> -pn,    --productName <product-name>                       Product name
>                                                              Requirement 
> Rules:
>                                                               [IngestProduct 
> : REQUIRED, HasProduct : REQUIRED,
>                                                               
> GetProductByName : REQUIRED, DeleteProductByName :
>                                                               REQUIRED]
> 
>                                                              Handler:
>                                                               Will invoke 
> 'setProductName' on action selected,
>                                                               except for the 
> following actions: []
> 
> -vc,    --versionClass <classpath>                         ProductType 
> versioner class
>                                                              Requirement 
> Rules:
>                                                               [AddProductType 
> : REQUIRED]
> 
>                                                              Handler:
>                                                               Will invoke 
> 'setVersionClass' on action selected,
>                                                               except for the 
> following actions: [AddProductType
>                                                               : setVersioner]
> 
> -mf,    --metadataFile <file-path-or-url>                  Metadata XML file 
> path or URL
>                                                              Requirement 
> Rules:
>                                                               [IngestProduct 
> : REQUIRED]
> 
>                                                              Handler:
>                                                               Will invoke 
> 'setMetadataFile' on action selected,
>                                                               except for the 
> following actions: []
> 
> -curPage,--currentPageNum <page-number>                     Current Page 
> Number
>                                                              Requirement 
> Rules:
>                                                               [GetNextPage : 
> REQUIRED, GetPrevPage : REQUIRED]
> 
>                                                              Handler:
>                                                               Will invoke 
> 'setCurrentPageNum' on action
>                                                               selected, 
> except for the following actions: []
> 
> -ps,    --productStructure <structure-type>                Hierarchical | Flat
>                                                              Requirement 
> Rules:
>                                                               [IngestProduct 
> : REQUIRED]
> 
>                                                              Handler:
>                                                               Will invoke 
> 'setProductStructure' on action
>                                                               selected, 
> except for the following actions:
>                                                               [IngestProduct 
> : setProductStructure]
> 
> -ptn,   --productTypeName <product-type-name>              ProductType name
>                                                              Requirement 
> Rules:
>                                                               [IngestProduct 
> : REQUIRED, GetProductTypeByName :
>                                                               REQUIRED, 
> GetNumProducts : REQUIRED, GetFirstPage
>                                                               : REQUIRED, 
> GetNextPage : REQUIRED, GetPrevPage :
>                                                               REQUIRED, 
> GetLastPage : REQUIRED,
>                                                               
> GetProductPercentTransferred : REQUIRED]
> 
>                                                              Handler:
>                                                               Will invoke 
> 'setProductTypeName' on action
>                                                               selected, 
> except for the following actions: []
> 
> -rs,    --refs <file-path-or-url>                          Data file path or 
> URL
>                                                              Requirement 
> Rules:
>                                                               [IngestProduct 
> : REQUIRED]
> 
>                                                              Handler:
>                                                               Will invoke 
> 'setRefs' on action selected, except
>                                                               for the 
> following actions: [IngestProduct :
>                                                               setReferences]
> 
> -repo,  --repository <file-path>                           ProductType 
> repository
>                                                              Requirement 
> Rules:
>                                                               [AddProductType 
> : REQUIRED]
> 
>                                                              Handler:
>                                                               Will invoke 
> 'setRepository' on action selected,
>                                                               except for the 
> following actions: [AddProductType
>                                                               : 
> setFileRepositoryPath]
> 
> -sb,    --sortBy <metadata field>                          Metadata field to 
> sort query results by
>                                                              Requirement 
> Rules:
>                                                               [SqlQuery : 
> OPTIONAL]
> 
>                                                              Handler:
>                                                               Will invoke 
> 'setSortBy' on action selected, except
>                                                               for the foll

Reply via email to