----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4089/#review5437 -----------------------------------------------------------
trunk/commons/src/main/java/org/apache/oodt/commons/util/DateConvert.java <https://reviews.apache.org/r/4089/#comment11841> might want to also add here "...24 characters in length or null." to the exception message. - Chris On 2012-02-28 20:05:18, Ricky Nguyen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4089/ > ----------------------------------------------------------- > > (Updated 2012-02-28 20:05:18) > > > Review request for oodt. > > > Summary > ------- > > When DateConvert.isoParse is given a null input, it throws NPE. > Solution is throw ParseException if input is null. WorkflowInstance catches > ParseException and ignores it. > > > This addresses bug OODT-361. > https://issues.apache.org/jira/browse/OODT-361 > > > Diffs > ----- > > trunk/commons/src/main/java/org/apache/oodt/commons/util/DateConvert.java > 1294802 > > Diff: https://reviews.apache.org/r/4089/diff > > > Testing > ------- > > Ran HelloWorld, GoodbyeWorld. > > > Thanks, > > Ricky > >
