----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4196/#review5818 -----------------------------------------------------------
Hey Brian, one of the ideas I had on this was to maintain like back compat with the existing PCS_ keys and not *force* folks to have to upgrade to them (which would force them to update the configs). One idea I had for doing this was to maintain like 2 interfaces, one for v1-keys (the "_" delimited ones), and another for v2-keys (the "/" delimited ones), and then allow folks using CAS-PGE to switch between them with a config file option in the pge-config.xml. Thoughts? I can work this up if you are +1. - Chris On 2012-03-09 08:17:12, brian Foster wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4196/ > ----------------------------------------------------------- > > (Updated 2012-03-09 08:17:12) > > > Review request for oodt, Chris Mattmann and Paul Ramirez. > > > Summary > ------- > > This includes the changes from wengine-branch cas-pge... still needs to add > backwards compatibility for MetKeys (i.e. PCS_* etc) > > > This addresses bug OODT-262. > https://issues.apache.org/jira/browse/OODT-262 > > > Diffs > ----- > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java > 1297147 > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/FileBasedPgeConfigBuilder.java > PRE-CREATION > trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/FileStagingInfo.java > PRE-CREATION > trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfig.java > 1297147 > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfigBuilder.java > 1297147 > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfigMetKeys.java > 1297147 > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java > 1297147 > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PGETaskMetKeys.java > PRE-CREATION > trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeMetadata.java > 1297147 > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileManagerFileStager.java > PRE-CREATION > trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileStager.java > PRE-CREATION > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/PcsMetFileWriter.java > 1297147 > > Diff: https://reviews.apache.org/r/4196/diff > > > Testing > ------- > > > Thanks, > > brian > >
