----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4393/ -----------------------------------------------------------
(Updated 2012-03-17 20:19:38.958054) Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett. Changes ------- Updated unit-tests and updates per chris's comments Summary ------- The 2 main issues here (and they are small changes) are: - CAS-PGE now fails when products fail to ingest * this was the changes found in createPgeConfig() and the addition of the key to PgeTaskMetKeys - PgeConfigBuilder is configurable via PgeTaskMetKeys * this was the removal of the Exception catching in: runIngestCrawler The other issue is just overall improvement to PgeTaskInstance logging ALSO: run(Metadata, WorkflowTaskConfiguration) method was moved to the top for better visibility This addresses bugs OODT-418, OODT-419 and OODT-420. https://issues.apache.org/jira/browse/OODT-418 https://issues.apache.org/jira/browse/OODT-419 https://issues.apache.org/jira/browse/OODT-420 Diffs (updated) ----- trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1301762 trunk/pge/src/test/org/apache/oodt/cas/pge/config/MockPgeConfigBuilder.java PRE-CREATION trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java 1301761 trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogHandler.java 1301762 trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogRecord.java 1301762 trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 1301762 trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1301762 trunk/pge/src/test/org/apache/oodt/cas/pge/logging/TestPgeLogHandler.java 1301762 Diff: https://reviews.apache.org/r/4393/diff Testing ------- Still need to write unit-test for this patch... Thanks, brian