----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4399/#review6073 -----------------------------------------------------------
Ship it! LGTM - Chris On 2012-03-18 21:26:02, brian Foster wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4399/ > ----------------------------------------------------------- > > (Updated 2012-03-18 21:26:02) > > > Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and > Thomas Bennett. > > > Summary > ------- > > This is the OODT-Commons portion of this change > > > This addresses bug OODT-423. > https://issues.apache.org/jira/browse/OODT-423 > > > Diffs > ----- > > trunk/commons/src/main/java/org/apache/oodt/commons/exec/ExecUtils.java > 1302040 > > trunk/commons/src/main/java/org/apache/oodt/commons/io/LoggerOutputStream.java > 1302040 > > trunk/commons/src/test/org/apache/oodt/commons/io/TestLoggerOutputStream.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/4399/diff > > > Testing > ------- > > Updated/Added unit-tests > > > Thanks, > > brian > >