----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4451/#review6344 -----------------------------------------------------------
Ship it! LGTM! trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResult.java <https://reviews.apache.org/r/4451/#comment13771> Nice. - Chris On 2012-03-23 21:02:03, Ricky Nguyen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4451/ > ----------------------------------------------------------- > > (Updated 2012-03-23 21:02:03) > > > Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl > John, and Thomas Bennett. > > > Summary > ------- > > Cleaned up metadata to string methods of QueryResult. If metadata was empty, > it was trying to delete a trailing comma that doesn't exist. > > > This addresses bug OODT-427. > https://issues.apache.org/jira/browse/OODT-427 > > > Diffs > ----- > > > trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResult.java > 1303205 > > trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestSqlQueryCliAction.java > 1303205 > > trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResult.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/4451/diff > > > Testing > ------- > > Added unit test to check for empty metadata. > > Changed existing unit test to account for implementation-dependent ordering > of keys. > > > Thanks, > > Ricky > >
