----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4458/#review6282 -----------------------------------------------------------
Great patch!.... Couple comments trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java <https://reviews.apache.org/r/4458/#comment13625> Should handle case where both are null... will produce faster sorting time in cases where there are several nulls... something along the lines of: if (m1 == null) { If (m2 == null) { return 0; } return 1; } if (m2 == null) { return -1; } trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java <https://reviews.apache.org/r/4458/#comment13626> Maybe add test case with multiple nulls? - brian On 2012-03-23 00:10:25, Ricky Nguyen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4458/ > ----------------------------------------------------------- > > (Updated 2012-03-23 00:10:25) > > > Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl > John, and Thomas Bennett. > > > Summary > ------- > > putting nulls last > > > This addresses bug OODT-429. > https://issues.apache.org/jira/browse/OODT-429 > > > Diffs > ----- > > > trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java > 1303205 > > trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/4458/diff > > > Testing > ------- > > wrote unit test > > > Thanks, > > Ricky > >
