----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4465/#review6291 -----------------------------------------------------------
Ship it! LGTM... thanks Tom! - brian On 2012-03-23 09:47:04, Thomas Bennett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4465/ > ----------------------------------------------------------- > > (Updated 2012-03-23 09:47:04) > > > Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and > Sheryl John. > > > Summary > ------- > > As per Brian's suggestion, I needed to add > > <property name="type" value="boolean" /> > <property name="hasArgs" value="false" /> > <property name="staticArgs"> > <list> > <value>true</value> > </list> > </property> > > To all boolean type beans in the crawler cmd-line-options.xml file. > > So the following beans have been updated for the crawler: noRecur, > crawlForDirs, skipIngest, ignoreInvalidAddresses > > > This addresses bug https://issues.apache.org/jira/browse/OODT-430. > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/OODT-430 > > > Diffs > ----- > > trunk/crawler/src/main/resources/cmd-line-options.xml 1304212 > > Diff: https://reviews.apache.org/r/4465/diff > > > Testing > ------- > > I've tested executing with --noRecur, --crawlForDirs, --skipIngest, > --ignoreInvalidAddresses > > > Thanks, > > Thomas > >
