----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4454/#review6380 -----------------------------------------------------------
Ship it! Sounds good LGTM. - Chris On 2012-03-26 20:55:22, brian Foster wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4454/ > ----------------------------------------------------------- > > (Updated 2012-03-26 20:55:22) > > > Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and > Thomas Bennett. > > > Summary > ------- > > It currently was setting lists keys to: value1,value2,value3,... > > This patch will instead change it to: > key[0] = value1 > key[1] = value2 > > > This addresses bug OODT-428. > https://issues.apache.org/jira/browse/OODT-428 > > > Diffs > ----- > > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java > 1304041 > > trunk/crawler/src/test/org/apache/oodt/cas/crawl/cli/option/handler/TestCrawlerBeansPropHandler.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/4454/diff > > > Testing > ------- > > Wrote unit-test > > > Thanks, > > brian > >
