-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4553/
-----------------------------------------------------------

(Updated 2012-03-29 12:26:06.602271)


Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl 
John.


Changes
-------

Fixed my Eclipse editor to indent 3 spaces, soft tabs.


Summary
-------

Get product references before calling retrieveProduct().
1) call setProductReferences method
2) remove d.retrieveProduct() outside the if else statement.

Fix unit tests testRetrieveFilesById() and testRetrieveFilesByName()
1) last method call is now getProductReferences not 
getProductByName/getProductById
2) The last method call has the product passed in as the argument. The call has 
been modified to retrieve the productName/productId correctly from the method 
call.


This addresses bug OODT-433.
    https://issues.apache.org/jira/browse/OODT-433


Diffs (updated)
-----

  
trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/TestFileManagerCli.java 
1306745 
  
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/RetrieveFilesCliAction.java
 1306745 

Diff: https://reviews.apache.org/r/4553/diff


Testing
-------

* All unit tests now pass
* filemgr deployed and tested with the filemgr client using both local and 
remote data transfer factories.


Thanks,

Thomas

Reply via email to