----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4665/#review6733 -----------------------------------------------------------
Ship it! LGTM! - Chris On 2012-04-06 02:26:01, brian Foster wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4665/ > ----------------------------------------------------------- > > (Updated 2012-04-06 02:26:01) > > > Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and > Thomas Bennett. > > > Summary > ------- > > Also includes minor changes to spring file properties and a getter method i > added to MoveFile CrawlerAction for a unit-test in CAS-PGE > > > This addresses bug OODT-438. > https://issues.apache.org/jira/browse/OODT-438 > > > Diffs > ----- > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/MoveFile.java > 1310151 > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigReader.java > 1310151 > trunk/crawler/src/main/resources/action-beans.xml 1310151 > trunk/crawler/src/main/resources/precondition-beans.xml 1310151 > > Diff: https://reviews.apache.org/r/4665/diff > > > Testing > ------- > > need to add unit-test... however, current cas-pge patch for change to use > AutoDetectProductCrawler has a unit-test which verifies this works > > > Thanks, > > brian > >
