> On 2012-04-04 18:34:56, Chris Mattmann wrote: > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java, line > > 151 > > <https://reviews.apache.org/r/4628/diff/1/?file=98791#file98791line151> > > > > this seems like an ancillary change to this patch. However, it's a > > useful functionality so I don't feel strongly about separating it out. Just > > be wary of stuff like this (b/c as it grows) it can take away from the > > purpose of the patch ;)
ya... thought that too when i was making the change... but i was writing the unit-test for a method that was using it so i just fixed it right now so i don't have to rewrite the unit-test later > On 2012-04-04 18:34:56, Chris Mattmann wrote: > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/OutputDir.java, line > > 49 > > <https://reviews.apache.org/r/4628/diff/1/?file=98792#file98792line49> > > > > +like ack - brian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4628/#review6686 ----------------------------------------------------------- On 2012-04-06 02:16:10, brian Foster wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4628/ > ----------------------------------------------------------- > > (Updated 2012-04-06 02:16:10) > > > Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and > Thomas Bennett. > > > Summary > ------- > > CAS-PGE Changes to this issue... > - Renaming and Metadata extraction removed from CAS-PGE and instead CAS-PGE > now uses AutoDetectProductCrawler instead of StdProductCrawler > > > This addresses bug OODT-426. > https://issues.apache.org/jira/browse/OODT-426 > > > Diffs > ----- > > trunk/pge/src/main/resources/examples/Crawler/naming-beans.xml PRE-CREATION > trunk/pge/src/main/resources/examples/Crawler/precondition-beans.xml > PRE-CREATION > > trunk/pge/src/main/resources/examples/MetadataOutputFiles/metadata-output.xml > 1302648 > trunk/pge/src/main/resources/examples/PgeConfigFiles/pge-config.xml 1302648 > trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1302781 > trunk/pge/src/main/resources/examples/Crawler/mime-types.xml PRE-CREATION > trunk/pge/src/main/resources/examples/Crawler/mime-extractor-map.xml > PRE-CREATION > trunk/pge/src/main/resources/examples/Crawler/crawler-config.xml > PRE-CREATION > trunk/pge/src/main/resources/examples/Crawler/filename.extractor.config.xml > PRE-CREATION > trunk/pge/src/main/resources/examples/Crawler/action-beans.xml PRE-CREATION > trunk/pge/src/main/resources/examples/Crawler/action-beans.properties > PRE-CREATION > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/metlist/MetadataListPcsMetFileWriter.java > 1302648 > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/xslt/XslTransformWriter.java > 1302648 > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/SciPgeConfigFileWriter.java > 1302648 > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java > 1302648 > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java > 1302648 > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/ExternExtractorMetWriter.java > 1302648 > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/FilenameExtractorWriter.java > 1302648 > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/PcsMetFileWriter.java > 1302648 > trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/RenamingConv.java > 1302648 > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfigBuilder.java > 1302648 > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfigMetKeys.java > 1302648 > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/RegExprOutputFiles.java > 1302648 > trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/OutputDir.java > 1302648 > trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfig.java > 1302648 > trunk/pge/pom.xml 1302648 > trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java > 1302648 > > Diff: https://reviews.apache.org/r/4628/diff > > > Testing > ------- > > Several Unit-tests > > > Thanks, > > brian > >
