----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4746/#review7409 -----------------------------------------------------------
Ship it! LGTM, thanks bfost! - Chris On 2012-04-30 21:23:30, brian Foster wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4746/ > ----------------------------------------------------------- > > (Updated 2012-04-30 21:23:30) > > > Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and > Thomas Bennett. > > > Summary > ------- > > Will introduce a FileStaging abstract class with currently 1 implementation > using the FileManager. There will also be a new Config object which allow for > file paths or product ids which would you like to stage... this code will be > plugged in the XML configuration in a separate patch > > - This patch also include minor changes to log statments in PGETaskInstance > > > This addresses bug OODT-443. > https://issues.apache.org/jira/browse/OODT-443 > > > Diffs > ----- > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETask.java 1302648 > trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java > 1311492 > trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/FileStagingInfo.java > PRE-CREATION > trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfig.java > 1311492 > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java > 1311492 > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileManagerFileStager.java > PRE-CREATION > trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileStager.java > PRE-CREATION > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/util/GenericPgeObjectFactory.java > PRE-CREATION > trunk/pge/src/test/org/apache/oodt/cas/pge/staging/TestFileStager.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/4746/diff > > > Testing > ------- > > unit-tests > > > Thanks, > > brian > >
