----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4961/#review7482 -----------------------------------------------------------
like the patch!... few comments ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuerier.java <https://reviews.apache.org/r/4961/#comment16558> Why do you want Holding category to be returned? ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuerier.java <https://reviews.apache.org/r/4961/#comment16556> This should return a copy of runnableProcessors here... probably where your synchronization issue is ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java <https://reviews.apache.org/r/4961/#comment16554> getRunnableProcessors() is never null... probably should be a unit-test to insure that functionality ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java <https://reviews.apache.org/r/4961/#comment16555> !querier.getRunnableProcessors().isEmpty() ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java <https://reviews.apache.org/r/4961/#comment16565> When Success/done is passed in, the processor created is incorrect since it has a sub-processor in Queued/waiting ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java <https://reviews.apache.org/r/4961/#comment16560> Should probably add a NOT done processor here - brian On 2012-05-02 05:08:45, Chris Mattmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4961/ > ----------------------------------------------------------- > > (Updated 2012-05-02 05:08:45) > > > Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, Sheryl > John, and Thomas Bennett. > > > Summary > ------- > > Task Querier thread for OODT-310. See javadocs on: > https://builds.apache.org/job/oodt-trunk/javadoc/org/apache/oodt/cas/workflow/engine/TaskQuerier.html > > > This addresses bug OODT-310. > https://issues.apache.org/jira/browse/OODT-310 > > > Diffs > ----- > > > ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuerier.java > 1332505 > > ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/WorkflowProcessor.java > 1331866 > > ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/4961/diff > > > Testing > ------- > > Includes unit test, that currently isn't passing. I think I know why > (something up with my threading logic and synchronized keywords) but wanted > to throw it up for review. I'll likely be working on this tomorrow or the > following evening. > > > Thanks, > > Chris > >
