----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6166/#review9525 -----------------------------------------------------------
trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/protocol/ProtocolHandler.java <https://reviews.apache.org/r/6166/#comment20370> I think making these vars final is orthogonal, but certainly an improvement ;) trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/FileRetrievalSystem.java <https://reviews.apache.org/r/6166/#comment20372> I don't see a Maven update here, do we need to add the google.common.base dep? trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/RetrievalSetup.java <https://reviews.apache.org/r/6166/#comment20371> orthogonal again with finals, but OK :) - Chris Mattmann On July 27, 2012, 12:15 a.m., brian Foster wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6166/ > ----------------------------------------------------------- > > (Updated July 27, 2012, 12:15 a.m.) > > > Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and > Thomas Bennett. > > > Description > ------- > > Causes NullPointerException: > SEVERE: Failed to finish downloading per property files > /home/yhkang/oodt/cas-pushpull/etc/examples/DirStructXmlParserFiles/RTG_SST.xml > : null > java.lang.NullPointerException > at > org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.validate(FileRetrievalSystem.java:367) > at > org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.changeToDir(FileRetrievalSystem.java:311) > at > org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.changeToDir(FileRetrievalSystem.java:300) > at > org.apache.oodt.cas.pushpull.retrievalmethod.RemoteCrawler.processPropFile(RemoteCrawler.java:103) > at > org.apache.oodt.cas.pushpull.retrievalsystem.RetrievalSetup.retrieveFiles(RetrievalSetup.java:109) > at org.apache.oodt.cas.pushpull.daemon.Daemon$1.run(Daemon.java:218) > at java.lang.Thread.run(Thread.java:662) > > > This addresses bug OODT-476. > https://issues.apache.org/jira/browse/OODT-476 > > > Diffs > ----- > > > trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/protocol/ProtocolHandler.java > 1365306 > > trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/protocol/RemoteSiteFile.java > 1365306 > > trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalmethod/RemoteCrawler.java > 1365306 > > trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/FileRetrievalSystem.java > 1365306 > > trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/RetrievalSetup.java > 1365306 > > Diff: https://reviews.apache.org/r/6166/diff/ > > > Testing > ------- > > Ran test provided by YunHee > > > Thanks, > > brian Foster > >
