> On Dec. 15, 2012, 7:04 p.m., Chris Mattmann wrote: > > ./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalog.java, > > line 57 > > <https://reviews.apache.org/r/8616/diff/1/?file=239036#file239036line57> > > > > Changes like this I don't get -- even if they are auto generated by > > Eclipse -- they're extraneous since they are just moved higher up in the > > file.
No problem - I can move the OODT imports on top and the JDK imports on the bottom. As you say, Eclipse likes it better the other way around... > On Dec. 15, 2012, 7:04 p.m., Chris Mattmann wrote: > > ./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalog.java, > > line 399 > > <https://reviews.apache.org/r/8616/diff/1/?file=239036#file239036line399> > > > > can we change quoteit to be quoteIt (camel case, Java style?) No problem, done. > On Dec. 15, 2012, 7:04 p.m., Chris Mattmann wrote: > > ./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/LenientDataSourceCatalog.java, > > line 96 > > <https://reviews.apache.org/r/8616/diff/1/?file=239038#file239038line96> > > > > why is this a FIXME? I should have removed the FIXME, it was a reminder for me about where I changed the original source. Assuring consistency in the product metadata between "CAS.productId" and the product id is the cirrect thing to do. > On Dec. 15, 2012, 7:04 p.m., Chris Mattmann wrote: > > ./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalog.java, > > line 2250 > > <https://reviews.apache.org/r/8616/diff/1/?file=239036#file239036line2250> > > > > It would be great to change this to quoteIt. Yes, changed. - Luca ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8616/#review14542 ----------------------------------------------------------- On Dec. 15, 2012, 7 p.m., Chris Mattmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8616/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2012, 7 p.m.) > > > Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, Thomas > Bennett, and Cameron Goodale. > > > Description > ------- > > Patch from Luca Cinquini and I to implement support for UUID based Data > Source Catalogs. > > > This addresses bug OODT-544. > https://issues.apache.org/jira/browse/OODT-544 > > > Diffs > ----- > > > ./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalog.java > 1422312 > > ./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalogFactory.java > 1422312 > > ./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/LenientDataSourceCatalog.java > PRE-CREATION > > ./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/util/DbStructFactory.java > 1422312 > > Diff: https://reviews.apache.org/r/8616/diff/ > > > Testing > ------- > > We have tested this on my transient detection project for V-FASTR. > > > Thanks, > > Chris Mattmann > >
