> On Jan. 30, 2013, 2:09 a.m., Chris Mattmann wrote:
> > /trunk/commons/src/main/java/org/apache/oodt/commons/exec/EnvUtilities.java,
> > line 77
> > <https://reviews.apache.org/r/9142/diff/1/?file=253029#file253029line77>
> >
> > Hey Mike, here we are no longer calling preProcessInputStream --
> > doesn't that do envVarReplace?
Chris, the only thing that this function does is "line =
line.replaceAll("\\\\", "\\\\\\\\");". There is no envVarReplace here. I did
some quick tests to see if this was an issue, but I will test this again to see
if I can get a better idea of any implications here.
Are you experiencing any specific problems?
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9142/#review15817
-----------------------------------------------------------
On Jan. 29, 2013, 9:25 p.m., Michael Starch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9142/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2013, 9:25 p.m.)
>
>
> Review request for oodt and Chris Mattmann.
>
>
> Description
> -------
>
> This is a review for a patch for JIRA issue OODT-553
> (https://issues.apache.org/jira/browse/OODT-553). It fixes the EnvUtilities.
> to use System.getEnvironment and not exec "env".
>
>
> Diffs
> -----
>
> /trunk/commons/src/main/java/org/apache/oodt/commons/exec/EnvUtilities.java
> 1439711
> /trunk/commons/src/test/org/apache/oodt/commons/exec/TestEnvUtilities.java
> 1439711
>
> Diff: https://reviews.apache.org/r/9142/diff/
>
>
> Testing
> -------
>
> Wrote several new unit tests that test this on unix systems only as it
> requires USER and HOME env vars to be set.
>
>
> Thanks,
>
> Michael Starch
>
>
